RFR: 8317976: Optimize SIMD sort for AMD Zen 4 [v2]

Rohit Arul Raj rraj at openjdk.org
Mon Mar 17 17:22:08 UTC 2025


On Mon, 17 Mar 2025 17:00:28 GMT, Srinivas Vamsi Parasa <sparasa at openjdk.org> wrote:

>> Rohit Arul Raj has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   create a separate method to check for cpu's supporting avx512 version of simd sort
>
> src/hotspot/cpu/x86/vm_version_x86.hpp line 777:
> 
>> 775: 
>> 776:   static bool supports_avx512_simd_sort() {
>> 777:     //  Disable AVX512 version of SIMD Sort on AMD Zen4 Processors
> 
> Looks like you forgot to remove the comment: `// Disable AVX512 version of SIMD Sort on AMD Zen4 Processors`

For Zen4, we are disabling AVX512 version of SIMD Sort and using AVX2 version. So the comment is valid.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24053#discussion_r1999275419


More information about the hotspot-compiler-dev mailing list