RFR: 8346888: [ubsan] block.cpp:1617:30: runtime error: 9.97582e+36 is outside the range of representable values of type 'int'

[Tom Rodriguez]

On Sun, 16 Mar 2025 19:18:31 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> This code seems to be really old, from https://bugs.openjdk.org/browse/JDK-6743900.  Tagging reviewers @tkrodriguez and @vnkozlov .  To me, the formula for `to_pct` looks wrong.  I would expect `b->_freq` and `target->_freq `to be multiplied together, not divided.
>
> Block::_freq is number of times this block is executed per each call of the method. It could be big number for blocks in loop and very small on not frequent path.
> 
> `succ_prob()` is calculated based on frequencies of two block and/or corresponding branch probability: [gcm.cpp#L2100](https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/gcm.cpp#L2100)
> 
> `freq = b->_freq * b->succ_prob(j)` is number of times we take this outgoing path. So to calculate probability of taking this path in `target` block we divide `freq` on number of times `target` block is executed.
> 
> This assumes that `b->_freq` <= `target->freq`. Which seems not true in this case and indicate a bug in how we calculate and update blocks frequencies.

I agree with Vladimir that it seems like something is wrong with the block probabilities.  In product it would be fine to simply clamp these values in the range of 0..100 since they are just used to compute `CFGEdge::_infrequent` so the worst thing you get is a less good layout.  Refactoring the expressions so it's more clear what the requirements wouldn't hurt either.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23962#discussion_r1999355343