RFR: 8347555: [REDO] C2: implement optimization for series of Add of unique value [v7]

[Kangcheng Xu]

On Thu, 13 Mar 2025 09:09:21 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Kangcheng Xu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add micro benchmark
>
> test/hotspot/jtreg/compiler/c2/TestSerialAdditions.java line 310:
> 
>> 308:         CON3_L = genL.next();
>> 309:         CON4_L = genL.next();
>> 310:     }
> 
> Is there a reason why you are restricting the values to `powerOfTwoLongs`? I think it would be better if you just take the most general generator.
> 
> private static final RestrictableGenerator<Integer> GEN_INT = Generators.G.ints();
> private static final RestrictableGenerator<Long> GEN_LONG = Generators.G.longs();

Sorry misunderstood your previous comment. I thought you wanted to test especially power-of-two's. Now I understand you meant more "interesting" randoms (potentially close to power-of-two's)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23506#discussion_r1999461474