RFR: 8316694: Implement relocation of nmethod within CodeCache [v4]

[Chad Rakoczy]

On Sat, 15 Mar 2025 00:15:33 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Chad Rakoczy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix build issues
>
> src/hotspot/cpu/aarch64/relocInfo_aarch64.cpp line 93:
> 
>> 91: void trampoline_stub_Relocation::pd_fix_owner_after_move() {
>> 92:   NativeCall* call = nativeCall_at(owner());
>> 93:   assert(call->raw_destination() == owner(), "destination should be empty");
> 
> Why it was removed?

It was updated and moved [here](https://github.com/openjdk/jdk/pull/23573/files#diff-d69de3a692f24763ca460ed1cba2231ea76d5d98fc7e5018032981d9968221a6R380). This check expects trampoline stubs to be unresolved which may not be the case at the time of nmethod relocation

> src/hotspot/share/code/nmethod.hpp line 338:
> 
>> 336:           );
>> 337: 
>> 338:   nmethod(nmethod& nm);
> 
> No need this

Thanks forgot to delete this

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23573#discussion_r1999635674
PR Review Comment: https://git.openjdk.org/jdk/pull/23573#discussion_r1999636248