RFR: 8316694: Implement relocation of nmethod within CodeCache [v4]

[Chad Rakoczy]

On Mon, 17 Mar 2025 13:10:20 GMT, Evgeny Astigeevich <eastigeevich at openjdk.org> wrote:

>> Chad Rakoczy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix build issues
>
> src/hotspot/share/code/nmethod.cpp line 1471:
> 
>> 1469:     // Clear inline caches before acquiring any locks
>> 1470:     VM_ClearNMethodICs clear_nmethod_ics(nm);
>> 1471:     VMThread::execute(&clear_nmethod_ics);
> 
> This does not look correct.
> Why are you doing this?
> What are you trying to fix?

[Fix relocation requires](https://github.com/openjdk/jdk/blob/19154f7af34bf6f13d61d7a9f05d6277964845d8/src/hotspot/share/code/relocInfo.hpp#L858-L860) that inline caches be cleared which [must be done at a safepoint](https://github.com/openjdk/jdk/blob/19154f7af34bf6f13d61d7a9f05d6277964845d8/src/hotspot/share/code/nmethod.cpp#L770).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23573#discussion_r1999658796