RFR: 8351952: [IR Framework]: allow ignoring methods that are not compilable [v2]

[Emanuel Peter]

On Mon, 17 Mar 2025 20:47:10 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   documentation from Christian
>
> Some first comments, will continue tomorrow :-)

@chhagedorn Thanks for the review and suggestions, I applied them all :)

> test/hotspot/jtreg/compiler/lib/ir_framework/TestFramework.java line 417:
> 
>> 415:      * test failure. However, if such cases are expected in a test class, this flag can be set to true, which
>> 416:      * allows the all test to pass even if there is no compilation. Any associated {@link IR} rule is only executed
>> 417:      * if the test method was compiled, and else it is ignored silently.
> 
> /**
>      * In rare cases, methods may not be compilable because of a compilation bailout. By default, this leads to a
>      * test failure. However, if such cases are expected in multiple methods in a test class, this flag can be set to
>      * true, which allows any test to pass even if there is a compilation bailout. If only selected methods are prone
>      * to bail out, it is preferred to use {@link Test#allowNotCompilable()} instead for more fine-grained control.
>      * By setting this flag, any associated {@link IR} rule of a test is only executed if the test method was compiled, 
>      * and else it is ignored silently.

Applied :)

> test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irmethod/NotCompilableIRMethod.java line 34:
> 
>> 32: /**
>> 33:  * This class represents a special IR method which was not compiled by the IR framework, but this was explicitly allowed
>> 34:  * by "allowNotCompilable".
> 
> Maybe add here in what context this is used:
> Suggestion:
> 
>  * by "allowNotCompilable". This happens when the compiler bails out of a compilation (i.e. no compilation) but we treat 
>  * this as valid case.

applied :)

> test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irmethod/NotCompilableIRMethodMatchResult.java line 35:
> 
>> 33: /**
>> 34:  * This class represents a special matching result of an IR method where the compilation output was completely empty,
>> 35:  * but this was exlicitly allowed by "allowNotCompilable".
> 
> Maybe also add the same addition from above here as well.

applied :)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24049#issuecomment-2731901963
PR Review Comment: https://git.openjdk.org/jdk/pull/24049#discussion_r2000343081
PR Review Comment: https://git.openjdk.org/jdk/pull/24049#discussion_r2000345809
PR Review Comment: https://git.openjdk.org/jdk/pull/24049#discussion_r2000345715