RFR: 8345485: C2 MergeLoads: merge adjacent array/native memory loads into larger load [v4]

Tue Mar 18 09:33:12 UTC 2025

On Tue, 18 Mar 2025 08:53:02 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> kuaiwei has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert extract value and add more tests
>
> src/hotspot/share/opto/memnode.cpp line 1902:
> 
>> 1900:   PhaseGVN* const      _phase;
>> 1901:   LoadNode* const       _load;
>> 1902:   int          _last_op_index;    // Index of the last item in merged_list
> 
> What is the `merged_list`? I could not find it.

It's defined in MergePrimitiveLoads::run . It looks unnecessary since I have _last_op in MergeLoadInfo.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24023#discussion_r2000576326