RFR: 8350578: Refactor useless Parse and Template Assertion Predicate elimination code by using a PredicateVisitor [v2]

Emanuel Peter epeter at openjdk.org
Tue Mar 18 14:21:10 UTC 2025


On Tue, 18 Mar 2025 14:14:40 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Introduce predicates_enums.hpp
>
> src/hotspot/share/opto/predicates.cpp line 1195:
> 
>> 1193:   mark_predicates_on_list_maybe_useful(_parse_predicates);
>> 1194:   mark_predicates_on_list_maybe_useful(_template_assertion_predicate_opaques);
>> 1195: }
> 
> Suggestion:
> 
> void EliminateUselessPredicates::mark_all_predicates_maybe_useful() const {
>   mark_predicates_on_list_maybe_useful(_parse_predicates);
>   mark_predicates_on_list_maybe_useful(_template_assertion_predicate_opaques);
> }

For consistency?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24013#discussion_r2001160628


More information about the hotspot-compiler-dev mailing list