RFR: 8350589: Investigate cleaner implementation of AArch64 ML-DSA intrinsic introduced in JDK-8348561 [v5]

[Dean Long]

On Mon, 17 Mar 2025 14:08:37 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> This PR reworks the existing AArch64 ML_DSA intrinsic code generator to make it clearer to read and easier to maintain.
>
> Andrew Dinn has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
> 
>  - use references and const to avoid VSeq copying and fix int array arg issue
>  - fix comment
>  - fix invalid register argument
>  - fix errors in comments
>  - fix whitespace errors
>  - Clearer implementation of AArch64 dilithium generator

I'm not an expert, but this looks good overall, and I'm relying on Andrew's testing to verify the details.

-------------

Marked as reviewed by dlong (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24026#pullrequestreview-2696581482