RFR: 8352248: Check if CMoveX is supported [v2]

[Hamlin Li]

On Wed, 19 Mar 2025 07:34:07 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

> Looks reasonable.

Thank you!

> src/hotspot/share/opto/movenode.cpp line 204:
> 
>> 202: 
>> 203: bool CMoveNode::supported(const Type* t) {
>> 204:   switch( t->basic_type() ) {
> 
> Suggestion:
> 
>   switch (t->basic_type()) {

Fixed.

> src/hotspot/share/opto/movenode.cpp line 214:
> 
>> 212:     default:
>> 213:     ShouldNotReachHere();
>> 214:     return false;
> 
> Indentation:
> Suggestion:
> 
>       ShouldNotReachHere();
>       return false;

Fixed.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24095#issuecomment-2735937111
PR Review Comment: https://git.openjdk.org/jdk/pull/24095#discussion_r2002895314
PR Review Comment: https://git.openjdk.org/jdk/pull/24095#discussion_r2002895502