RFR: 8341908: CodeHeapAnalytics: Output Imperfections and unwanted vm termination [v3]

[Amit Kumar]

On Tue, 11 Feb 2025 21:06:48 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:

>> Output is properly aligned again now. Was messed up when method hotness was removed (part of method sweeper).
>> Assertions have been replaced by printing an error message and gracefully returning. Avoids vm crashes caused by diagnostic actions.
>> Some code restructuring, removal of redundancies.
>> 
>> Reviews are highly welcomed.
>
> Lutz Schmidt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8341908: fix make error

src/hotspot/share/code/codeHeapState.cpp line 2391:

> 2389: 
> 2390: void CodeHeapState::print_line_delim(outputStream* out, bufferedStream* ast, char* low_bound, unsigned int ix, unsigned int gpl) {
> 2391:   // Note: out and ast MUST NOT designate the SAME stream!

Was this intentional? Wouldn't an assert be better than a Note :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21452#discussion_r2002910506