RFR: 8314999: IR framework fails to detect allocation [v4]

Marc Chevalier duke at openjdk.org
Wed Mar 19 12:58:17 UTC 2025


On Wed, 19 Mar 2025 12:37:19 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Marc Chevalier has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   revert also formatting
>
> src/hotspot/share/opto/callnode.hpp line 1068:
> 
>> 1066: #ifndef PRODUCT
>> 1067:   virtual void dump_spec(outputStream* st) const;
>> 1068: #endif
> 
> For single line not product `defs`, you can use:
> Suggestion:
> 
>   NOT_PRODUCT(virtual void dump_spec(outputStream* st) const;)

Done. It is shorter, and I don't see a good reason not to use it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24093#discussion_r2003264188


More information about the hotspot-compiler-dev mailing list