RFR: 8350563: C2 compilation fails because PhaseCCP does not reach a fixpoint [v4]

[Liam Miller-Cushon]

On Wed, 19 Mar 2025 15:59:20 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Liam Miller-Cushon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments
>
> test/hotspot/jtreg/compiler/ccp/TestAndConZeroCCP.java line 31:
> 
>> 29:  * @run driver compiler.c2.TestAndConZeroCCP
>> 30:  */
>> 31: package compiler.c2;
> 
> You should update this to `ccp` now that you moved the test and use `main` instead of `driver`. Otherwise, `@run driver` is never executed with additionally passed in flags, for example in higher tier.
> Suggestion:
> 
>  * @run main/othervm -Xbatch -XX:-TieredCompilation compiler.ccp.TestAndConZeroCCP
>  * @run driver compiler.ccp.TestAndConZeroCCP
>  */
> package compiler.ccp;

Done

> test/hotspot/jtreg/compiler/ccp/TestAndConZeroCCP.java line 37:
> 
>> 35: public class TestAndConZeroCCP {
>> 36: 
>> 37:   public static void main(String[] args) {
> 
> You should use a 4 space indentation for Java tests.

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23871#discussion_r2003722869
PR Review Comment: https://git.openjdk.org/jdk/pull/23871#discussion_r2003722755