RFR: 8350589: Investigate cleaner implementation of AArch64 ML-DSA intrinsic introduced in JDK-8348561 [v5]

Ferenc Rakoczi duke at openjdk.org
Wed Mar 19 17:17:24 UTC 2025


On Mon, 17 Mar 2025 14:08:37 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> This PR reworks the existing AArch64 ML_DSA intrinsic code generator to make it clearer to read and easier to maintain.
>
> Andrew Dinn has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
> 
>  - use references and const to avoid VSeq copying and fix int array arg issue
>  - fix comment
>  - fix invalid register argument
>  - fix errors in comments
>  - fix whitespace errors
>  - Clearer implementation of AArch64 dilithium generator

It all looks great to me, the comments are good (a little too verbose for my taste, but they explain well what is happening in the code).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24026#issuecomment-2737446124


More information about the hotspot-compiler-dev mailing list