RFR: 8350563: C2 compilation fails because PhaseCCP does not reach a fixpoint [v6]
Christian Hagedorn
chagedorn at openjdk.org
Thu Mar 20 06:08:09 UTC 2025
On Wed, 19 Mar 2025 16:18:33 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:
>> Hello, please consider this fix for [JDK-8350563](https://bugs.openjdk.org/browse/JDK-8350563) contributed by my colleague Matthias Ernst.
>>
>> https://github.com/openjdk/jdk/pull/22856 introduced a new `Value()` optimization for the pattern `AndIL(Con, Mask)`.
>> This optimization can look through CastNodes, and therefore requires additional logic in CCP to push these
>> transitive uses to the worklist.
>>
>> The optimization is closely related to analogous optimizations for SHIFT nodes, and we also extend the existing logic for
>> CCP worklist handling: the current logic is "if the shift input to a SHIFT node changes, push indirect AND node uses to the CCP worklist".
>> We extend it by adding "if the (new) type of a node is an IntegerType that `is_con, ...` to the predicate.
>
> Liam Miller-Cushon has updated the pull request incrementally with one additional commit since the last revision:
>
> Update test/hotspot/jtreg/compiler/ccp/TestAndConZeroCCP.java
>
> Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
Marked as reviewed by chagedorn (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/23871#pullrequestreview-2701367022
More information about the hotspot-compiler-dev
mailing list