Integrated: 8352317: Assertion failure during size estimation of BoxLockNode with -XX:+UseAPX
Jatin Bhateja
jbhateja at openjdk.org
Thu Mar 20 18:59:12 UTC 2025
On Wed, 19 Mar 2025 06:50:39 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
> This patch fixes a crash during PhaseOutput while estimating the size of BoxLockNode.
> LEA instruction used to load the stack location holding a thread-specific lock in fast locking mode did not account for an additional byte of REX2 prefix if the destination register is an EGPR.
>
> LEA GPR/EGPR OFFSET(RSP).
>
> This fixed multiple issues seen in SPECjvm2008 worklets.
>
> The issue can be reproduced after changing the static allocation ordering in x86_64.ad giving preference to the EGPR register.
> [JDK-8343294](https://bugs.openjdk.org/browse/JDK-8343294) tracks the requirement to randomize the allocation sequence.
>
> Kindly review and share your feedback.
>
> Best Regards,
> Jatin
This pull request has now been integrated.
Changeset: 56038fb5
Author: Jatin Bhateja <jbhateja at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/56038fb5a156568cce2e80f5db18b10ad61c06e4
Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod
8352317: Assertion failure during size estimation of BoxLockNode with -XX:+UseAPX
Reviewed-by: thartmann
-------------
PR: https://git.openjdk.org/jdk/pull/24109
More information about the hotspot-compiler-dev
mailing list