RFR: 8211759: C2: Graph after optimizations should not have dead nodes

[Christian Hagedorn]

On Sun, 23 Mar 2025 08:23:43 GMT, Zihao Lin <duke at openjdk.org> wrote:

> Move the check_no_dead_use() call after the final_graph_reshaping() call to catch dead nodes.

When reading the description and the linked review thread in the JBS issue, it sounds like there are possibly cases where dead nodes could still be here after `final_graph_reshaping()` and this should be addressed with this JBS issue. Your patch now suggests that there are no (more?) such cases and the "no dead node" verification can simply be moved after `final_graph_reshaping()`. Can you elaborate more on how you concluded that and/or what kind of testing you did to have enough confidence that this is indeed the case?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24175#issuecomment-2747377775