RFR: 8302459: Missing late inline cleanup causes compiler/vectorapi/VectorLogicalOpIdentityTest.java IR failure [v5]
Tobias Hartmann
thartmann at openjdk.org
Mon Mar 24 12:18:13 UTC 2025
On Mon, 24 Mar 2025 12:14:11 GMT, Damon Fenacci <dfenacci at openjdk.org> wrote:
>> Okay, thanks for the background. If we keep both asserts, some comments explaining this would be helpful.
>
> Thanks for the suggestion!
> I've added a couple of comments to the asserts.
> I've also changed the second assert into `assert(!is_scheduled_for_igvn_before || is_scheduled_for_igvn_after, "call node removed from IGVN list during inlining pass");`. The final result is the same but the expression matches what the message says 1-1.
Looks good to me, thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21682#discussion_r2010065659
More information about the hotspot-compiler-dev
mailing list