RFR: 8350579: Remove Template Assertion Predicates belonging to a loop once it is folded away [v2]

Emanuel Peter epeter at openjdk.org
Mon Mar 24 12:37:22 UTC 2025


On Mon, 24 Mar 2025 12:23:38 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
>> 
>>  - Small things
>>  - Fix test comments
>>  - New approach: Marking unrelated Template Assertion Predicates outside of IGVN by storing a reference to the loop it originally was created for.
>>  - Merge branch 'master' into JDK-8350579
>>  - Revert fix completely
>>  - 8350579: Remove Template Assertion Predicates belonging to a
>>     loop once it is folded away during IGVN
>
> src/hotspot/share/opto/loopTransform.cpp line 1706:
> 
>> 1704:   // Compute the value of the loop induction variable at the end of the
>> 1705:   // first iteration of the unrolled loop: init + new_stride_con - init_inc
>> 1706:   int unrolled_stride_con = stride_con_before_unroll * 2;
> 
> Could we assert that `stride_con_before_unroll == main_loop_head->stride_con()`?

If not, could we assert something similar?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23823#discussion_r2010080552


More information about the hotspot-compiler-dev mailing list