RFR: 8325467: Support methods with many arguments in C2 [v10]

[Daniel Lundén]

On Mon, 24 Mar 2025 13:40:57 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove accidental leftover #endif
>
> src/hotspot/share/opto/regmask.hpp line 188:
> 
>> 186:   // all registers/stack locations under _lwm and over _hwm are excluded.
>> 187:   // The exception is (s10, s11, ...), where the value is decided solely by
>> 188:   // _all_stack, regardless of the value of _hwm.
> 
> This comment illustrates the case with `_offset = 0`, I think it would be useful to extend it with an example where `_offset > 0`. Here is a suggestion: https://github.com/openjdk/jdk/commit/8377012ac485a70703921822d58bc535bafb7a0a. Feel free to merge as-is or edit to your liking, if you agree.

Looks good to me, now merged. There are likely other opportunities for more source code comment illustrations throughout `regmask.hpp`. `SUBTRACT_inner` and `overlap` comes to mind, in particular. I'll have a look and see what can be improved.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20404#discussion_r2010426174