RFR: 8350609: Cleanup unknown unwind opcode (0xB) for windows
Vivek Deshpande
duke at openjdk.org
Mon Mar 24 16:27:12 UTC 2025
On Fri, 21 Mar 2025 18:05:54 GMT, Dhamoder Nalla <dhanalla at openjdk.org> wrote:
>>> @dhanalla As @vivdesh asked above: do you have a regression test for this?
>>>
>>> You also have this warning above:
>>>
>>> Warning ⚠️ Found leading lowercase letter in issue title for 8350609: cleanup unknown unwind opcode (0xB) for windows
>> I addressed the warning, and regarding regression tests, I have validated the Jtreg Tier 1 tests, including vector-specific tests under /test/jdk/incubator/vector.
>
>> @dhanalla Thanks for fixing the waring and running some tests!
>>
>> From my understanding, those tests passed before your patch here, correct? If so, then I'm wondering if there could be a regression test for this "unknown unwind opcode", that fails before your patch and passes with your patch? How feasible is that?
>
> Thanks @eme64,
> We are just cleaning up the unknown unwind codes that are not required. The unwind instructions in the .text section remain untouched.
> The only difference we see after this change is that the output of 'dumpbin.exe /unwindinfo jsvml.dll' will no longer display any unknown unwind opcodes identified in the DLL corresponding to these methods.
Thanks @dhanalla. Looks good to me as well.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23707#issuecomment-2748708478
More information about the hotspot-compiler-dev
mailing list