RFR: 8352595: Regression of JDK-8314999 in IR matching [v3]

Tobias Hartmann thartmann at openjdk.org
Tue Mar 25 07:21:10 UTC 2025


On Mon, 24 Mar 2025 14:35:36 GMT, Marc Chevalier <duke at openjdk.org> wrote:

>> A lot of tests for the IR framework used `ALLOC` and friends as a check that would run on the Opto assembly by default, but can also run earlier, but that's no longer the case.
>> 
>> There were two kinds of tests to fix: the ones rather about `ALLOC`, where the used or expected compile phases have to change, and the tests where `ALLOC` were just a check that would run on opto assembly. For this, I tried to keep the spirit of the test using other regexes made for this stage.
>
> Marc Chevalier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Merge branch 'master' into fix/fix-IRframework-test
>  - wip
>  - wip
>  - Fix TestCompilePhaseCollector.java
>  - Fix TestPhaseIRMatching.java
>  - Fix TestBadFormat

Looks good to me too. Ship it!

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24163#pullrequestreview-2712657320


More information about the hotspot-compiler-dev mailing list