RFR: 8347459: C2: missing transformation for chain of shifts/multiplications by constants [v17]

[duke]

On Mon, 24 Mar 2025 13:09:02 GMT, Marc Chevalier <duke at openjdk.org> wrote:

>> This collapses double shift lefts by constants in a single constant: (x << con1) << con2 => x << (con1 + con2). Care must be taken in the case con1 + con2 is bigger than the number of bits in the integer type. In this case, we must simplify to 0.
>> 
>> Moreover, the simplification logic of the sign extension trick had to be improved. For instance, we use `(x << 16) >> 16` to convert a 32 bits into a 16 bits integer, with sign extension. When storing this into a 16-bit field, this can be simplified into simple `x`. But in the case where `x` is itself a left-shift expression, say `y << 3`, this PR makes the IR looks like `(y << 19) >> 16` instead of the old `((y << 3) << 16) >> 16`. The former logic didn't handle the case where the left and the right shift have different magnitude. In this PR, I generalize this simplification to cases where the left shift has a larger magnitude than the right shift. This improvement was needed not to miss vectorization opportunities: without the simplification, we have a left shift and a right shift instead of a single left shift, which confuses the type inference.
>> 
>> This also works for multiplications by powers of 2 since they are already translated into shifts.
>> 
>> Thanks,
>> Marc
>
> Marc Chevalier has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 31 additional commits since the last revision:
> 
>  - Merge branch 'master' into fix/missing-transformation-for-chain-of-shifts-multiplications-by-constants
>  - Rephrase comment
>  - more checks
>  - order
>  - rephrase
>  - correct
>  - s
>  - rephrased corner case
>  - rephrase
>  - char -> byte
>  - ... and 21 more: https://git.openjdk.org/jdk/compare/30067c8b...cd0b0c09

@marc-chevalier 
Your change (at version cd0b0c093fa2fe80d287cc0b5bd703ee2a4ad5b1) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23728#issuecomment-2750395127