RFR: 8350579: Remove Template Assertion Predicates belonging to a loop once it is folded away [v2]
Emanuel Peter
epeter at openjdk.org
Tue Mar 25 08:27:14 UTC 2025
On Mon, 24 Mar 2025 15:31:03 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> If not, could we assert something similar?
>
> I thought about somehow asserting here that as well. But the problem is that at this point, we already concatenated the original and the new loop together to represent one round of unrolling. So, we do not find the original loop exit check anymore from which we could have read the stride. That's why I explicitly take the cached `stride_con_before_unroll` and double it here.
>
> We could have maybe cached the original loop exit node somehow to query it. But I don't think it adds much value since it's as good the original stride which was read from the loop exit node.
Makes sense. The assert is not that important here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23823#discussion_r2011555211
More information about the hotspot-compiler-dev
mailing list