RFR: 8352585: Add special case handling for Float16.max/min x86 backend [v2]
Sandhya Viswanathan
sviswanathan at openjdk.org
Tue Mar 25 15:04:20 UTC 2025
On Tue, 25 Mar 2025 08:31:06 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
>> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 7093:
>>
>>> 7091: }
>>> 7092:
>>> 7093: void C2_MacroAssembler::scalar_max_min_fp16(int opcode, XMMRegister dst, XMMRegister src1, XMMRegister src2,
>>
>> Any reason we are not doing this on lines of scalar emit_fp_min_max? For most common cases emit_fp_min_max based sequence would have much better latency.
>
> We don't need any blend emulation on CPUs supporting AVX512-FP16, it's specific to E-core targets.
emit_fp_min_max in x86_64.ad doesn't have any blend emulation.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24169#discussion_r2012311161
More information about the hotspot-compiler-dev
mailing list