RFR: 8352141: UBSAN: fix the left shift of negative value in relocInfo.cpp, internal_word_Relocation::pack_data_to()
Vladimir Kozlov
kvn at openjdk.org
Tue Mar 25 18:45:19 UTC 2025
On Mon, 24 Mar 2025 13:18:25 GMT, Afshin Zafari <azafari at openjdk.org> wrote:
> The `offset` variable used in left-shift op can be a large number with its sign-bit set. This makes a negative value which is UB for left-shift and is reported as
> `runtime error: left shift of negative value -25 at relocInfo.cpp:...`
>
> Using `java_left_shif()` function is the workaround to avoid UB. This function uses reinterpret_cast to cast from signed to unsigned and back.
>
> Tests:
> linux-x64-debug tier1 on a UBSAN enabled build.
May be we should wait conclusion of discussion for https://github.com/openjdk/jdk/pull/24184
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24196#issuecomment-2752209587
More information about the hotspot-compiler-dev
mailing list