RFR: 8352617: IR framework test TestCompileCommandFileWriter.java runs TestCompilePhaseCollector instead of itself
Christian Hagedorn
chagedorn at openjdk.org
Wed Mar 26 09:41:26 UTC 2025
On Wed, 26 Mar 2025 07:36:37 GMT, Marc Chevalier <mchevalier at openjdk.org> wrote:
> Simply changing the path in `@run` was not enough (see JBS for details). And actually, the test wasn't doing anything before trying to open an output file to check the result. From various hints, I completed the test: I hope it was the intent!
>
> I think @chhagedorn's eye would be the most relevant.
>
> Thanks,
> Marc
Good catch! I'm not sure why I removed this one line. It surely must have been exactly what you added now. Maybe I was doing some last experiments and somehow messed up to push it properly and then we missed it because it was actually not even run.
-------------
Marked as reviewed by chagedorn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24240#pullrequestreview-2716449643
More information about the hotspot-compiler-dev
mailing list