RFR: 8316694: Implement relocation of nmethod within CodeCache [v7]

Wed Mar 26 12:48:22 UTC 2025

On Wed, 26 Mar 2025 12:43:22 GMT, Evgeny Astigeevich <eastigeevich at openjdk.org> wrote:

>> Chad Rakoczy has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Relocate nmethod at safepoint
>>  - Fix windows build
>
> src/hotspot/share/code/nmethod.cpp line 1492:
> 
>> 1490:   // Relocate nmethod at safepoint
>> 1491:   VM_RelocateNMethod relocate_nmethod(nm, code_blob_type);
>> 1492:   VMThread::execute(&relocate_nmethod);
> 
> You should not do this here. It will be a responsibility of a caller to ensure relocation is done at a safepoint.  A caller will get to a safepoint and relocate a bunch of nmethods.

In your PR this will be responsibility of WhiteBox.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23573#discussion_r2014067304