RFR: 8352617: IR framework test TestCompileCommandFileWriter.java runs TestCompilePhaseCollector instead of itself
Tobias Hartmann
thartmann at openjdk.org
Thu Mar 27 07:37:15 UTC 2025
On Wed, 26 Mar 2025 07:36:37 GMT, Marc Chevalier <mchevalier at openjdk.org> wrote:
> Simply changing the path in `@run` was not enough (see JBS for details). And actually, the test wasn't doing anything before trying to open an output file to check the result. From various hints, I completed the test: I hope it was the intent!
>
> I think @chhagedorn's eye would be the most relevant.
>
> Thanks,
> Marc
test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/flag/TestCompileCommandFileWriter.java line 47:
> 45: * @run driver jdk.test.lib.helpers.ClassFileInstaller jdk.test.whitebox.WhiteBox
> 46: * @run junit/othervm -Xbootclasspath/a:. -DSkipWhiteBoxInstall=true -XX:+IgnoreUnrecognizedVMOptions -XX:+UnlockDiagnosticVMOptions
> 47: * -XX:+WhiteBoxAPI compiler.lib.ir_framework.flag.TestCompileCommandFileWriter
Do we really need the WhiteBoxAPI? `-XX:+IgnoreUnrecognizedVMOptions` can be removed as well. Please also update the copyright date.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24240#discussion_r2015830209
More information about the hotspot-compiler-dev
mailing list