RFR: 8352617: IR framework test TestCompileCommandFileWriter.java runs TestCompilePhaseCollector instead of itself [v2]

Marc Chevalier mchevalier at openjdk.org
Thu Mar 27 08:48:51 UTC 2025


> Simply changing the path in `@run` was not enough (see JBS for details). And actually, the test wasn't doing anything before trying to open an output file to check the result. From various hints, I completed the test: I hope it was the intent!
> 
> I think @chhagedorn's eye would be the most relevant.
> 
> Thanks,
> Marc

Marc Chevalier has updated the pull request incrementally with one additional commit since the last revision:

  fix copyright and remove IgnoreUnrecognizedVMOptions and remove vm.debug

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/24240/files
  - new: https://git.openjdk.org/jdk/pull/24240/files/321ebab8..437a4913

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=24240&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=24240&range=00-01

  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/24240.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/24240/head:pull/24240

PR: https://git.openjdk.org/jdk/pull/24240


More information about the hotspot-compiler-dev mailing list