RFR: 8352869: Verify.checkEQ: extension for NaN, VectorAPI and arbitrary Objects [v3]

[Emanuel Peter]

On Fri, 28 Mar 2025 05:04:42 GMT, Galder Zamarreño <galder at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update test/hotspot/jtreg/compiler/lib/verify/Verify.java
>>   
>>   Co-authored-by: Galder Zamarreño <galder at redhat.com>
>
> test/hotspot/jtreg/compiler/lib/verify/Verify.java line 264:
> 
>> 262:     private void checkEQimpl(float a, float b, String field, Object aParent, Object bParent) {
>> 263:         if (isFloatEQ(a, b)) {
>> 264:             System.err.println("ERROR: Verify.checkEQ failed: value mismatch. check raw: " + isFloatCheckWithRawBits);
> 
> Would using a text block here make it more readable?

@galderz What do you mean by a text block? String Templates would be nice, but we don't have them. Do you mean I should use `String.format`? But there is always so tricky to know what is going to be formatted to where...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24224#discussion_r2018220193