RFR: 8351140: RISC-V: Intrinsify Unsafe::setMemory [v2]

Anjian-Wen duke at openjdk.org
Fri Mar 28 12:50:18 UTC 2025


On Fri, 28 Mar 2025 11:29:56 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

> Unfortunately, 'UnsafeMemoryAccessMark' doesn't work like this. Your current implementation marks the code region in `unsafe_setmemory`, but the accesses are done in `StubRoutines::_jbyte_fill` which are outside of that region.

Thanks for the reminder. 
I'm not sure if I understand this correctly, you mean 'generate_fill(_jbyte_fill)' has reach a new block with get new 'pc' and new 'enter', but the 'UnsafeMemoryAccessMark' function in 'generate_unsafe_setmemory' only works inside the old block, so that it does not work correctly? 

I will spend some  more time sorting out this logic and try to fix it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23890#issuecomment-2761273256


More information about the hotspot-compiler-dev mailing list