RFR: 8352585: Add special case handling for Float16.max/min x86 backend [v6]

Sandhya Viswanathan sviswanathan at openjdk.org
Fri Mar 28 21:20:19 UTC 2025


On Fri, 28 Mar 2025 21:13:03 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adding custom NaN generator
>
> test/hotspot/jtreg/compiler/intrinsics/float16/TestFloat16MaxMinSpecialValues.java line 58:
> 
>> 56:         if (Float16.isNaN(actual) && Float16.isNaN(expected)) {
>> 57:             return false;
>> 58:         }
> 
> This should be:
>         if (Float16.isNaN(actual) ^ Float16.isNaN(expected)) {
>             return true;
>         }

Basically assert if one is NaN and other is not.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24169#discussion_r2019397591


More information about the hotspot-compiler-dev mailing list