RFR: 8348853: Fold layout helper check for objects implementing non-array interfaces [v2]
Marc Chevalier
mchevalier at openjdk.org
Mon Mar 31 09:37:08 UTC 2025
On Mon, 31 Mar 2025 06:46:51 GMT, Marc Chevalier <mchevalier at openjdk.org> wrote:
>> Now I'm confused, isn't this what I proposed? I didn't check the exact syntax, I just wondered if the `TypeInterfaces::contains` method couldn't be used instead of adding a new method.
>
> Yes, totally! It's just a detail difference. But there is another question: whether we still want `has_non_array_interface` has a wrapper for this call with a more explicit name, or if we simply inline your suggestion on the callsite of `has_non_array_interface`. I tend toward the first, I like explicit names, and I suspect it might be useful in more than one place, but not a strong opinion.
For now, I just replaced the implementation of `has_non_array_interface`. If one feels even keeping the method is premature factorization, I can easily inline it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24245#discussion_r2020704570
More information about the hotspot-compiler-dev
mailing list