RFR: 8349479: C2: when a Type node becomes dead, make CFG path that uses it unreachable [v3]

[Roland Westrelin]

On Fri, 28 Mar 2025 18:41:58 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - review
>>  - Merge branch 'master' into JDK-8349479
>>  - review
>>  - whitespace
>>  - fix & test
>
> src/hotspot/share/opto/node.cpp line 3134:
> 
>> 3132:   size_t len = ss.size() + 1;
>> 3133:   char* arena_str = NEW_ARENA_ARRAY(igvn->C->comp_arena(), char, len);
>> 3134:   memcpy(arena_str, ss.base(), len);
> 
> Does it make sense to move it into `stringStream::as_string()`? `stringStream::as_string()` already handles resource area and C-heap allocations.

It does make sense. Implemented in new commit. I added a new method and there's some code duplication but it felt better than adding one more optional argument to the existing method. What do you think?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23468#discussion_r2020758391