RFR: 8344942: Template-Based Testing Framework [v2]
Emanuel Peter
epeter at openjdk.org
Mon Mar 31 10:57:17 UTC 2025
On Mon, 31 Mar 2025 08:09:35 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Emanuel Peter has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>>
>> - Merge branch 'master' into JDK-8344942-TemplateFramework-v3
>> - fix tests
>> - whitespace
>> - whitespace
>> - fix whitespace
>> - JDK-8344942
>
> test/hotspot/jtreg/compiler/lib/template_framework/README.md line 8:
>
>> 6: The basic functionalities of the Template Framework are described in the [Template Class](./Template.java), together with some examples. More examples can be found in [TestSimple.java](../../../testlibrary_tests/template_framework/examples/TestSimple.java) and [TestTutorial.java](../../../testlibrary_tests/template_framework/examples/TestTutorial.java).
>> 7:
>> 8: The [Template Library](../template_library/README.md) provides a large number of Templates which can be used to create anything from simple regression tests to complex fuzzers.
>
> `template_library/README.md` does not exist.
>
> Another thought: Should `template_library` be a subfolder in `template_framework`? Otherwise, it could suggest to be something separate from the Template Framework.
Removing that line, and moving the library to a subfolder.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2020823170
More information about the hotspot-compiler-dev
mailing list