RFR: 8352893: C2: OrL/INode::add_ring optimize (x | -1) to -1 [v2]

[Manuel Hässig]

On Mon, 31 Mar 2025 13:55:08 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Manuel Hässig has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix bug number in regression test
>
> test/hotspot/jtreg/compiler/integerArithmetic/TestOrSaturate.java line 32:
> 
>> 30:  /*
>> 31:   * @test
>> 32:   * @bug 8352839
> 
> Suggestion:
> 
>   * @bug 8352893
> 
> Werchstabeverbuechslig ;)

Fixed in [f286eee](https://github.com/openjdk/jdk/pull/24289/commits/f286eee0cb3f1ee55c4b1903c9d4e019bd9a4e57)

> test/hotspot/jtreg/compiler/integerArithmetic/TestOrSaturate.java line 47:
> 
>> 45:     @Run(test = {"testL", "testI", "testDelayed"})
>> 46:     public static void check() {
>> 47:         for (int i = 0; i < WARMUP; i++) {
> 
> Do you actually need the WARMUP here? It does not look like this is a standalone test, so I thought the `@Run` actually gets called many times. Not sure if that is correct...

The name `WARMUP` is not strictly correct, but I left the loop to test more than one value.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24289#discussion_r2021109966
PR Review Comment: https://git.openjdk.org/jdk/pull/24289#discussion_r2021107880