RFR: 8355704: RISC-V: enable TestIRFma.java [v2]

Hamlin Li mli at openjdk.org
Thu May 1 08:36:29 UTC 2025


On Wed, 30 Apr 2025 14:42:59 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/c2/irTests/TestIRFma.java line 89:
>> 
>>> 87: 
>>> 88:     @Test
>>> 89:     @IR(counts = {IRNode.FMSUB_F, "> 0", IRNode.NEG_F, "> 0"},
>> 
>> What is the reason for adding the "IRNode.NEG_F" ?
>
> I think I need to reconsider the test improvement, will update the pr later.
> 
> Thank for having a look.

I'll keep the test simple, let IR verification to verify the optimal FmaF/D nodes are generated, and let asserts to verify the functionality of these nodes are right. So it's a bit different from another platform, which verify the specific instructs are finally generated in "FINAL CODE" phase, which is not bad, but seems over-complicated and over-white-boxed, and different platforms could have different instruct names for the same IR node (which is the case in FMA on riscv and aarch64). And I'll leave aarch64 untouched.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24947#discussion_r2069990316


More information about the hotspot-compiler-dev mailing list