RFR: 8315066: Add unsigned bounds and known bits to TypeInt/Long [v55]

Emanuel Peter epeter at openjdk.org
Thu May 1 16:01:20 UTC 2025


On Thu, 1 May 2025 15:47:56 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Emanuel's reviews
>
> src/hotspot/share/opto/type.cpp line 1848:
> 
>> 1846:     // The widen bits must be allowed to run freely through the graph.
>> 1847:     return (new TypeInt(TypeIntPrototype<jint, juint>{{ft->_lo, ft->_hi}, {ft->_ulo, ft->_uhi}, ft->_bits},
>> 1848:                         this->_widen, false))->hashcons();
> 
> Why not use `TypeInt::make`?

Also: when do you have to do `hashcons` and when is it ok without?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17508#discussion_r2070447069


More information about the hotspot-compiler-dev mailing list