RFR: 8315066: Add unsigned bounds and known bits to TypeInt/Long [v56]

Emanuel Peter epeter at openjdk.org
Fri May 2 09:11:08 UTC 2025


On Fri, 2 May 2025 08:17:41 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Emanuel's reviews
>
> src/hotspot/share/utilities/intn_t.hpp line 37:
> 
>> 35: template <unsigned int n>
>> 36: class intn_t {
>> 37:   static_assert(n > 0 && n <= 8, "should not be larger than char");
> 
> Does `n` stand for the number of bits? Maybe you could write `bits` or even `NUM_BITS` instead?

Maybe it's not worth it. But then it should be explained in the class description comment above :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17508#discussion_r2071267929


More information about the hotspot-compiler-dev mailing list