RFR: 8315066: Add unsigned bounds and known bits to TypeInt/Long [v56]
Quan Anh Mai
qamai at openjdk.org
Fri May 2 11:28:21 UTC 2025
On Fri, 2 May 2025 08:34:08 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Maybe it's not worth it. But then it should be explained in the class description comment above :)
>
> Suggestion:
>
> static_assert(0 < n && n <= 8, "should not be larger than char");
>
> And I like things ordered according to their value :)
> Does `n` stand for the number of bits? Maybe you could write `bits` or even `NUM_BITS` instead?
I changed it to `nbits`.
> And I like things ordered according to their value :)
Fine, this one follows you :)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17508#discussion_r2071471665
More information about the hotspot-compiler-dev
mailing list