RFR: 8355674: C2: Partial Peeling should not introduce Phi nodes above OpaqueInitializedAssertionPredicate nodes
Christian Hagedorn
chagedorn at openjdk.org
Fri May 2 13:49:02 UTC 2025
In the test case, we have two Initialized Assertion Predicate that share the same `Bool` which is perfectly fine:

These Initialized Assertion Predicates were created for loops that have been folded away. They then end up in a new inner most loop which is partial peeled. Partial Peeling finds that we need to do the cut between `580 IfTrue` and `581 If`. This means, that the Initialized Assertion Predicate `569 RangeCheck` with its `535 OpaqueInitializedAssertionPredicate` is in the peel set and the second Initialized Assertion Predicate `504 RangeCheck` with its `503 OpaqueInitializedAssertionPredicate` is in the not peel set. As a result of that, we are introducing a `Phi` node between an `OpaqueInitializedAssertionPredicate` and a `Bool` node:

We eventually remove the `OpaqueInitializedAssertionPredicate` and are left with the following graph shape

which cannot be handled by the backend.
The fix I propose is to prohibit Partial Peeling from inserting such a `Phi` node by updating `clone_for_special_use_inside_loop()` which takes care of not inserting phis for an `If/Bool`. We need to also special case `OpaqueInitializedAssertionPredicate`.
Thanks,
Christian
-------------
Commit messages:
- 8355674: C2: Partial Peeling should not introduce Phi nodes above OpaqueInitializedAssertionPredicate nodes
Changes: https://git.openjdk.org/jdk/pull/25006/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25006&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8355674
Stats: 56 lines in 2 files changed: 55 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/25006.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/25006/head:pull/25006
PR: https://git.openjdk.org/jdk/pull/25006
More information about the hotspot-compiler-dev
mailing list