RFR: 8315066: Add unsigned bounds and known bits to TypeInt/Long [v53]

Emanuel Peter epeter at openjdk.org
Fri May 2 15:42:04 UTC 2025


On Fri, 2 May 2025 11:39:32 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> @merykitty Ok, now I'm through the whole thing. I am doing this review more thorough and nit-picky than others, because it is going to be quite a substantial change, and quite at the core of many IGVN optimizations going forward.
>> 
>> Again: I'm really impressed by the bit tricks here, and very happy that we now have quite solid explanations / proofs.
>> 
>> Once you tell me that you responded to all comments here, I can make another pass over everything :)
>
> @eme64 Please let me know if you disagree with any answer from me. I am fairly confident in this patch, especially with the exhaustive tests exercising `intn_t<nbits>` values. After this patch, I will work on allowing the test infrastructure to work with `Type` instances directly, templatizing `TypeInt` and `TypeLong` so that we can work with `TypeInt<intn_t<nbits>>`.

@merykitty Ok, that is all I can do this week, enjoy the weekend 👋 😊 
If I don't resume commenting on Monday then feel free to ping me with a reminder 😉

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17508#issuecomment-2847522055


More information about the hotspot-compiler-dev mailing list