RFR: 8356030: RISC-V: enable (part of) BasicDoubleOpTest.java
Manuel Hässig
duke at openjdk.org
Mon May 5 12:22:46 UTC 2025
On Thu, 1 May 2025 11:31:50 GMT, Hamlin Li <mli at openjdk.org> wrote:
> Hi,
> Can you help to review this patch?
> Originally, I was going to enable all test cases on riscv in this test file. But seems there was already a try to implement RoundDoubleModeV (which is IRNode.ROUND_DOUBLE_MODE_V) in https://github.com/openjdk/jdk/pull/21164, but failed because of some performance regression.
> So I'll just enable part of test cases in this pr.
>
> Thanks!
Looks good to me as well. I also ran some testing that passed fine.
-------------
Marked as reviewed by mhaessig at github.com (no known OpenJDK username).
PR Review: https://git.openjdk.org/jdk/pull/24983#pullrequestreview-2814621074
More information about the hotspot-compiler-dev
mailing list