RFR: 8356188: RISC-V: Cleanup effect of vmaskcmp_fp [v2]

Gui Cao gcao at openjdk.org
Tue May 6 02:52:13 UTC 2025


On Tue, 6 May 2025 02:42:32 GMT, Dingli Zhang <dzhang at openjdk.org> wrote:

>> Hi all,
>> Please take a look and review this PR, thanks!
>> 
>> See "The RISC-V Instruction Set Manual" at https://riscv.org/technical/specifications/. In the Vector Floating-Point Compare Instructions section:
>> 
>> The destination mask vector register may be the same as the source vector mask register (v0).
>> 
>> Also, the integer form of `vmaskcmp` has no effect too, so remove the effect of vmaskcmp_fp.
>> 
>> ### Testing
>> qemu-system 9.1.0 with UseRVV (ubuntu24.10):
>> * [x]  Run test/jdk/jdk/incubator/vector (fastdebug)
>
> Dingli Zhang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8356188
>  - 8356188: RISC-V: Cleanup effect of vmaskcmp_fp

Looks good to me.

-------------

Marked as reviewed by gcao (Author).

PR Review: https://git.openjdk.org/jdk/pull/25055#pullrequestreview-2816731409


More information about the hotspot-compiler-dev mailing list