RFR: 8352869: Verify.checkEQ: extension for NaN, VectorAPI and arbitrary Objects [v15]

Christian Hagedorn chagedorn at openjdk.org
Tue May 6 06:29:28 UTC 2025


On Mon, 5 May 2025 13:06:36 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> We should extend the functionality of Verify.checkEQ:
>> - Allow different NaN encodings to be seen as equal (by default).
>> - Compare VectorAPI vectors.
>> - Compare Exceptions, and their messages.
>> - Compare arbitrary Objects via Reflection.
>> 
>> Note: this is a prerequisite for the Template Library [JDK-8352861](https://bugs.openjdk.org/browse/JDK-8352861) / https://github.com/openjdk/jdk/pull/23418.
>
> Emanuel Peter has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 17 additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8352869-Verify-NaN-Vector-Objects
>  - Apply Tobias' review suggestions
>    
>    Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>  - Apply suggestions from code review
>    
>    Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>  - For Christian
>  - Apply suggestions from code review
>    
>    Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>  - fix whitespace issues
>  - Updates for Christian
>  - Apply suggestions from code review
>    
>    Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>  - refactor with checkEQWithRawBits
>  - upate copyright
>  - ... and 7 more: https://git.openjdk.org/jdk/compare/d24a8877...23a22389

Marked as reviewed by chagedorn (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/24224#pullrequestreview-2816991583


More information about the hotspot-compiler-dev mailing list