RFR: 8355699: RISC-V: support SUADD/SADD/SUSUB/SSUB [v2]

Ludovic Henry luhenry at openjdk.org
Tue May 6 13:10:29 UTC 2025


On Tue, 6 May 2025 09:12:16 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Hi,
>> Can you help to review this patch to add SUADD/SADD/SUSUB/SSUB for vector api?
>> 
>> Thanks!
>> 
>> ## Test
>> data
>> <google-sheets-html-origin style="caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0); font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;">
>> Benchmark | (size) | Mode | Cnt | Score - master | Score - patch | improvement (master/patch)
>> -- | -- | -- | -- | -- | -- | --
>> ByteMaxVector.SADD | 1024 | avgt | 10 | 23693.941 | 381.441 | 62.117
>> ByteMaxVector.SSUB | 1024 | avgt | 10 | 24067.009 | 379.836 | 63.362
>> ByteMaxVector.SUADD | 1024 | avgt | 10 | 24131.819 | 382.678 | 63.06
>> ByteMaxVector.SUSUB | 1024 | avgt | 10 | 23140.494 | 380.768 | 60.773
>> IntMaxVector.SADD | 1024 | avgt | 10 | 88526.058 | 1378.77 | 64.207
>> IntMaxVector.SSUB | 1024 | avgt | 10 | 94204.768 | 1383.613 | 68.086
>> IntMaxVector.SUADD | 1024 | avgt | 10 | 82470.743 | 1384.668 | 59.56
>> IntMaxVector.SUSUB | 1024 | avgt | 10 | 84443.805 | 1759.69 | 47.988
>> LongMaxVector.SADD | 1024 | avgt | 10 | 187690.117 | 3770.84 | 49.774
>> LongMaxVector.SSUB | 1024 | avgt | 10 | 187334.716 | 3814.869 | 49.106
>> LongMaxVector.SUADD | 1024 | avgt | 10 | 186891.578 | 2747.753 | 68.016
>> LongMaxVector.SUSUB | 1024 | avgt | 10 | 186092.582 | 2730.588 | 68.151
>> ShortMaxVector.SADD | 1024 | avgt | 10 | 43991.814 | 726.703 | 60.536
>> ShortMaxVector.SSUB | 1024 | avgt | 10 | 40560.356 | 730.238 | 55.544
>> ShortMaxVector.SUADD | 1024 | avgt | 10 | 43349.632 | 729.758 | 59.403
>> ShortMaxVector.SUSUB | 1024 | avgt | 10 | 42686.701 | 726.059 | 58.792
>> 
>> </google-sheets-html-origin>
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   minor

Marked as reviewed by luhenry (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/25005#pullrequestreview-2818215012


More information about the hotspot-compiler-dev mailing list