RFR: 8355704: RISC-V: enable TestIRFma.java [v2]
Ludovic Henry
luhenry at openjdk.org
Tue May 6 13:11:21 UTC 2025
On Thu, 1 May 2025 08:36:29 GMT, Hamlin Li <mli at openjdk.org> wrote:
>> Hi,
>> Can you help to review this patch to enable TestIRFma.java?
>> FmaF/D (checked by TestIRFma.java) are supported on riscv, but for some reason we can not enable it easily, but we should enable it.
>>
>> NOTE: the reason I change IRNode matching rules is that, previously it verify the `FINAL CODE` where every platform could have different instruct name; I change it from machOnlyNameRegex to beforeMatchingNameRegex, to make it verify the `PrintIdeal` where every platform share the same names.
>>
>> Also tested on machine with `asimd` support.
>>
>> Thanks!
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>
> adjust IR verification
Marked as reviewed by luhenry (Committer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/24947#pullrequestreview-2818217833
More information about the hotspot-compiler-dev
mailing list