RFR: 8355674: C2: Partial Peeling should not introduce Phi nodes above OpaqueInitializedAssertionPredicate nodes [v2]

Christian Hagedorn chagedorn at openjdk.org
Tue May 6 17:21:56 UTC 2025


On Tue, 6 May 2025 16:53:11 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add run with Xbatch
>
> test/hotspot/jtreg/compiler/predicates/assertion/TestPhiAboveOpaqueInitializedAssertionPredicate.java line 29:
> 
>> 27:  * @summary Check that we do not introduce a Phi above a OpaqueInitializedAssertionPredicateNode during Partial Peeling.
>> 28:  * @run main/othervm -Xcomp -XX:CompileOnly=compiler.predicates.assertion.TestPhiAboveOpaqueInitializedAssertionPredicate::test
>> 29:  *                   compiler.predicates.assertion.TestPhiAboveOpaqueInitializedAssertionPredicate
> 
> What about a run without `Xcomp`?

We would probably then also need to add some more invocations of `test()` inside `main()`. Probably does not hurt. The test is quite fast. I've updated the test.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25006#discussion_r2075933957


More information about the hotspot-compiler-dev mailing list