RFR: 8356328: Some C2 IR nodes miss size_of() function [v2]

kuaiwei duke at openjdk.org
Wed May 7 08:27:54 UTC 2025


> I wrote a test to check if every C2 IR node has correct size_of() function. And I found some of them are missed. They added new fields and not add size_of() to reflect new size. In linux, it does not cause issue so far, because gcc allocate more space for alignment and can keep these additional `bool` flags. But it will report failure on windows. And if anyone modified base class, it will cause problem.
> 
> PS, My test is in https://github.com/openjdk/jdk/compare/master...kuaiwei:jdk:test/check_node_size , but it has many hack on IR nodes to make test to run.

kuaiwei has updated the pull request incrementally with one additional commit since the last revision:

  Add missing size_of() in machnode.hpp

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/25081/files
  - new: https://git.openjdk.org/jdk/pull/25081/files/c7054cb7..1eb11ad0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=25081&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25081&range=00-01

  Stats: 7 lines in 1 file changed: 7 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/25081.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25081/head:pull/25081

PR: https://git.openjdk.org/jdk/pull/25081


More information about the hotspot-compiler-dev mailing list